[webkit-reviews] review granted: [Bug 130156] Allocate the data section on the heap again for FTL on ARM64 : [Attachment 226549] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Juergen Ributzka
<juergen at apple.com>'s request for review:
Bug 130156: Allocate the data section on the heap again for FTL on ARM64
https://bugs.webkit.org/show_bug.cgi?id=130156

Attachment 226549: Patch
https://bugs.webkit.org/attachment.cgi?id=226549&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226549&action=review


r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:84
> +    // Allocate the GOT in the code section to make it reachable for all
code.
> +    if (!strcmp(sectionName, "__got"))
> +	   return mmAllocateCodeSection(opaqueState, size, alignment,
sectionID, sectionName);

As a follow-up, we'll need to allocate the GOT outside executable memory --
otherwise we're still subject to "JIT spray" attacks.