[webkit-reviews] review requested: [Bug 130176] WebKit shouldn't crash on uniprocessor machines : [Attachment 226574] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 22:35:54 PDT 2014


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 130176: WebKit shouldn't crash on uniprocessor machines
https://bugs.webkit.org/show_bug.cgi?id=130176

Attachment 226574: the patch
https://bugs.webkit.org/attachment.cgi?id=226574&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
It seems to me that the "minimum" in computeNumberOfWorkerThreads() is not
really the minimum after the subtraction of 1 in Options.h.  Could
computeNumberOfWorkerThreads() always have a true minimum of 1 and pass 1 or 7
as the maximum?  Or subtract the 1 in computeNumberOfWorkerThreads. Seems a
little better to have all the min/max calculation in one place,
computeNumberOfWorkerThreads.


More information about the webkit-reviews mailing list