[webkit-reviews] review granted: [Bug 130169] [iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments : [Attachment 226564] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 130169: [iOS] Use the window size instead of the device size to compute
device-width/device-height viewport arguments
https://bugs.webkit.org/show_bug.cgi?id=130169

Attachment 226564: Patch
https://bugs.webkit.org/attachment.cgi?id=226564&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review


> Source/WebCore/dom/ViewportArguments.cpp:-419
> +void finalizeViewportArguments(ViewportArguments& arguments, FloatSize
screenSize)
>  {
> -    CGSize screenSize = wkGetViewportScreenSize();
> -

As a temporary workaround:
What about modifying the screenSize to make it "in portrait", then use that
value to update ViewportArguments?