[webkit-reviews] review granted: [Bug 130162] [WebGL] WebKit1 + WebKit2 iOS clients should check load policy : [Attachment 226556] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 130162: [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
https://bugs.webkit.org/show_bug.cgi?id=130162

Attachment 226556: Patch
https://bugs.webkit.org/attachment.cgi?id=226556&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226556&action=review


> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h:205
> +    virtual WebCore::WebGLLoadPolicy webGLPolicyForURL(const String&) const
override;
> +    virtual WebCore::WebGLLoadPolicy resolveWebGLPolicyForURL(const String&)
const override;

I hope the difference between these two is explained in a comment in the base
class becuase it's not obvious.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:622
> +#if ENABLE(WEBGL) && !PLATFORM(MAC) && !PLATFORM(IOS)

!PLATFORM(COCOA)?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1767
> +    return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation;

UNUSED_PARAM() for frame and url?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1772
> +WebCore::WebGLLoadPolicy WebPage::resolveWebGLPolicyForURL(WebFrame* frame,
const String& url)
> +{
> +    return WKShouldBlockWebGL() ? WebGLBlockCreation : WebGLAllowCreation;

Ditto.