[webkit-reviews] review denied: [Bug 130152] Do not show extended background during a pinch gesture on iOS : [Attachment 226543] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 12:54:16 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 130152: Do not show extended background during a pinch gesture on iOS
https://bugs.webkit.org/show_bug.cgi?id=130152

Attachment 226543: Patch
https://bugs.webkit.org/attachment.cgi?id=226543&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226543&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:403
> +    UIColor *pageExtendedBackgroundColor = [self
pageExtendedBackgroundColor];
> +    if (pageExtendedBackgroundColor && [self _backgroundExtendsBeyondPage]
&& [_scrollView zoomScale] >= [_scrollView minimumZoomScale] && ![_scrollView
isZoomBouncing])
> +	   [_scrollView setBackgroundColor:pageExtendedBackgroundColor];
> +    else
> +	   [_scrollView setBackgroundColor:nil];

You'll need the same code executed in response to scrollViewDidZoom:


More information about the webkit-reviews mailing list