[webkit-reviews] review granted: [Bug 130119] Web Inspector: OS X View Indication : [Attachment 226480] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 12:07:03 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 130119: Web Inspector: OS X View Indication
https://bugs.webkit.org/show_bug.cgi?id=130119

Attachment 226480: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=226480&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226480&action=review


> Source/WebCore/inspector/InspectorOverlay.cpp:330
> +    return m_highlightNode || m_highlightNode || m_indicating ||
!m_pausedInDebuggerMessage.isNull();

We could remove m_pausedInDebuggerMessage (and friends), it is dead code to us.


More information about the webkit-reviews mailing list