[webkit-reviews] review granted: [Bug 130032] Web Inspector: Hang in Remote Inspection triggering breakpoint from console : [Attachment 226328] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 130032: Web Inspector: Hang in Remote Inspection triggering breakpoint from
console
https://bugs.webkit.org/show_bug.cgi?id=130032

Attachment 226328: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=226328&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226328&action=review


> Source/JavaScriptCore/inspector/EventLoop.cpp:43
> +CFStringRef EventLoop::remoteInspectorRunLoopMode()
> +{
> +    return CFSTR("com.apple.JavaScriptCore.remote-inspector-runloop-mode");
> +}

This makes EventLoop more about Inspector than before. But it is in the
inspector directory, so I guess it is fine.

>
Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm:1
23
> +	   CFRunLoopAddSource(CFRunLoopGetMain(), rwiRunLoopSource,
kCFRunLoopDefaultMode);
> +	   CFRunLoopAddSource(CFRunLoopGetMain(), rwiRunLoopSource,
EventLoop::remoteInspectorRunLoopMode());

Needs added to both so paused and non-paused works? Maybe add a comment?