[webkit-reviews] review granted: [Bug 129445] Web Replay: add infrastructure for auto-memoizing nondeterministic DOM APIs : [Attachment 226076] the complete patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 129445: Web Replay: add infrastructure for auto-memoizing nondeterministic
DOM APIs
https://bugs.webkit.org/show_bug.cgi?id=129445

Attachment 226076: the complete patch
https://bugs.webkit.org/attachment.cgi?id=226076&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226076&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2208
> +		   push(@implContent, "     }\n");

I'd add another \n here to give breathing room between the blocks.

> Source/WebCore/replay/MemoizedDOMResult.cpp:76
> +    encodedValue.put<String>("attribute", input.attribute());

These strings passed to put and get should use ASCIILiteral().