[webkit-reviews] review granted: [Bug 129857] Web Inspector: JSContext inspection - TypeError: null is not an object (evaluating 'contentView.showSourceCode') : [Attachment 226074] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 129857: Web Inspector: JSContext inspection - TypeError: null is not an
object (evaluating 'contentView.showSourceCode')
https://bugs.webkit.org/show_bug.cgi?id=129857

Attachment 226074: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=226074&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226074&action=review


I think this is fine. Only concern I have is the use of
this.parentSidebar.selectedSidebarPanel.show().

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:112
> +	       this.parentSidebar.selectedSidebarPanel.show();

I am not sure this is right. Why do we need to force the sidebar to show? A
comment would be good about why it is forced to show and why this uses
this.parentSidebar.selectedSidebarPanel.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:117
> +	   this.parentSidebar.selectedSidebarPanel.show();

Ditto.