[webkit-reviews] review granted: [Bug 128783] Web Inspector: DataGrid should have an API to set sort column and direction : [Attachment 226446] the patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 128783: Web Inspector: DataGrid should have an API to set sort column and
direction
https://bugs.webkit.org/show_bug.cgi?id=128783

Attachment 226446: the patch
https://bugs.webkit.org/attachment.cgi?id=226446&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226446&action=review


>
Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js:2
04
> +	   switch (this._dataGrid.sortColumnIdentifier || "url") {
> +	       case "url": comparator = localeCompare.bind(this, "url"); break;


Just use default:?

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:82
> +	       var columns = { name: {}, value: {}, domain: {}, path: {},
expires: {}, size: {}, http: {}, secure: {}};

No space after {.

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:141
> +	       };
> +	       if (cookie.type !== WebInspector.CookieType.Request)

Add a newline.