[webkit-reviews] review granted: [Bug 129981] Change scrollOffsetForFixedPosition() to do LayoutUnit math : [Attachment 226526] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 11:01:24 PDT 2014


Beth Dakin <bdakin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129981: Change scrollOffsetForFixedPosition() to do LayoutUnit math
https://bugs.webkit.org/show_bug.cgi?id=129981

Attachment 226526: Patch
https://bugs.webkit.org/attachment.cgi?id=226526&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226526&action=review


> Source/WebCore/page/FrameView.cpp:1542
> +    viewportRect.setLocation(LayoutPoint() +
scrollOffsetForFixedPosition());

Just out of curiosity, why is this better than toLayoutPoint() ?


More information about the webkit-reviews mailing list