[webkit-reviews] review granted: [Bug 130076] [GTK][CMAKE] Too verbose build output : [Attachment 226464] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 130076: [GTK][CMAKE] Too verbose build output
https://bugs.webkit.org/show_bug.cgi?id=130076

Attachment 226464: Patch
https://bugs.webkit.org/attachment.cgi?id=226464&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226464&action=review


This works great, I still would like that verbose targets use something like
Generating Foo for the cases where smart terminal is not used like in the bots
logs. Thanks.

> Source/cmake/OptionsGTK.cmake:311
> +file(COPY ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/build.sh
> +  DESTINATION ${CMAKE_BINARY_DIR}
> +  FILE_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ
GROUP_EXECUTE)

I wonder why you need to first write in one directory and then copy to another,
but I have no idea how cmake works :-P