[webkit-reviews] review granted: [Bug 129859] Subpixel rendering: Transform origin is miscalculated when RenderLayer's offsetfromRenderer has device pixel fraction value. : [Attachment 226469] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 129859: Subpixel rendering: Transform origin is miscalculated when
RenderLayer's offsetfromRenderer has device pixel fraction value.
https://bugs.webkit.org/show_bug.cgi?id=129859

Attachment 226469: Patch
https://bugs.webkit.org/attachment.cgi?id=226469&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226469&action=review


>
LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic
-expected.txt:114
> +	     (anchor 0.50 0.50)

Are these just slightly different from 0.5? Maybe we need to print more
precision.

> Source/WebCore/rendering/RenderLayerBacking.cpp:848
> +	   FloatPoint3D anchor(enclosingRelativeCompositingBounds.width() !=
0.0f ? ((layerOffset.x() - enclosingRelativeCompositingBounds.x()) +
transformOrigin.x())
> +	       / enclosingRelativeCompositingBounds.width() : 0.5f,
enclosingRelativeCompositingBounds.height() != 0.0f ? ((layerOffset.y() -
enclosingRelativeCompositingBounds.y())

0.0f -> 0, 0.5f -> 0.5