[webkit-reviews] review granted: [Bug 130091] Don't use NodeRenderingTraversal for pseudo elements : [Attachment 226437] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 130091: Don't use NodeRenderingTraversal for pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=130091

Attachment 226437: patch
https://bugs.webkit.org/attachment.cgi?id=226437&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226437&action=review


r=me

> Source/WebCore/dom/NodeRenderingTraversal.cpp:221
> +Node* firstChildSlow(const Node* node)

This code could be made more efficient by exploiting the knowledge that only
Elements will have the shouldUseNodeRenderingTraversalSlowPath bit set.

> Source/WebCore/dom/NodeRenderingTraversal.h:39
> +Node* lastChild(const Node*);

Where is this?

> Source/WebCore/dom/NodeRenderingTraversal.h:63
> +inline Node* firstChild(const Node* node)

Again, could be better with Element*.