[webkit-reviews] review granted: [Bug 130087] Webkit not building on XCode 5.1 due to garbage collection no longer being supported : [Attachment 226438] Rebased patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 11 15:46:32 PDT 2014
Mark Rowe (bdash) <mrowe at apple.com> has granted Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 130087: Webkit not building on XCode 5.1 due to garbage collection no
longer being supported
https://bugs.webkit.org/show_bug.cgi?id=130087
Attachment 226438: Rebased patch
https://bugs.webkit.org/attachment.cgi?id=226438&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Looks fine. You'll probably want to remove the #include of
UseInternalSDK.xcconfig from DebugRelease.xcconfig in each of the projects
you've modified though, otherwise people outside of Apple will get twice the
number of warnings about its absence.
More information about the webkit-reviews
mailing list