[webkit-reviews] review denied: [Bug 130087] Webkit not building on XCode 5.1 due to garbage collection no longer being supported : [Attachment 226424] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 11 09:56:16 PDT 2014


Mark Rowe (bdash) <mrowe at apple.com> has denied Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 130087: Webkit not building on XCode 5.1 due to garbage collection no
longer being supported
https://bugs.webkit.org/show_bug.cgi?id=130087

Attachment 226424: Patch
https://bugs.webkit.org/attachment.cgi?id=226424&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
We can't disable garbage collection entirely since that would be an
ABI-incompatible change, breaking clients of WebKit that build with GC enabled.
We'll need to disable it when USE_INTERNAL_SDK is unset and leave it set to
"supported" when USE_INTERNAL_SDK is YES.


More information about the webkit-reviews mailing list