[webkit-reviews] review granted: [Bug 34189] check-webkit-style failed to complain about missing braces : [Attachment 225982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 11 00:45:55 PDT 2014


Ryosuke Niwa <rniwa at webkit.org> has granted László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 34189: check-webkit-style failed to complain about missing braces
https://bugs.webkit.org/show_bug.cgi?id=34189

Attachment 225982: Patch
https://bugs.webkit.org/attachment.cgi?id=225982&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225982&action=review


rs=me.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2407
> +    if (match(r'^\s*\b(if|for|foreach|while|else)\b\s', line)

We don't want foreach here.


More information about the webkit-reviews mailing list