[webkit-reviews] review granted: [Bug 130066] REGRESSION(r165407): DoYouEvenBench crashes in DRT : [Attachment 226387] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 130066: REGRESSION(r165407): DoYouEvenBench crashes in DRT
https://bugs.webkit.org/show_bug.cgi?id=130066

Attachment 226387: Patch
https://bugs.webkit.org/attachment.cgi?id=226387&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226387&action=review


r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   The baseline JIT does a conditional store barrier for the put_by_id,
but we need 
> +	   an unconditional store barrier so that we cover the butterfly case
as well in emitPutTransitionStub.

I wonder if we should just remove conditional store barriers from the baseline
JIT -- to avoid mismatches like this, and because it wasn't a regression in the
optimizing JIT.