[webkit-reviews] review granted: [Bug 129955] Crash on a stack overflow on 32-bit x86 in http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html : [Attachment 226368] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 129955: Crash on a stack overflow on 32-bit x86 in
http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
https://bugs.webkit.org/show_bug.cgi?id=129955

Attachment 226368: the patch.
https://bugs.webkit.org/attachment.cgi?id=226368&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226368&action=review


r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   The 32-bit x86 version of getHostCallReturnValue() was leaking 16
bytes

Was it 16? I count 12:

push %ebp // 4
leal -4(%esp), %esp // 4
push %ebp // 4

> Source/JavaScriptCore/ChangeLog:9
> +	   stack memory every time it is called.  This is now fixed.

s/is called/was called/