[webkit-reviews] review granted: [Bug 130044] Web Inspector: Frontend loaded resources from cache are not hidden as expected : [Attachment 226345] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 17:28:58 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 130044: Web Inspector: Frontend loaded resources from cache are not hidden
as expected
https://bugs.webkit.org/show_bug.cgi?id=130044

Attachment 226345: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=226345&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226345&action=review


> Source/WebCore/loader/FrameLoader.cpp:3002
>      newRequest = ResourceRequest(resource->url());

It might just be best if the caller did this. That would remove the dance you
have to do.


More information about the webkit-reviews mailing list