[webkit-reviews] review granted: [Bug 130047] Expose runJavascript API to WKWebView : [Attachment 226347] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Paul Hankes Drielsma
<hankesdrielsma at apple.com>'s request for review:
Bug 130047: Expose runJavascript API to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=130047

Attachment 226347: Patch
https://bugs.webkit.org/attachment.cgi?id=226347&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226347&action=review


> Source/WebKit2/ChangeLog:3
> +	   Add SPI to run javascript in main frame on WKWebView.

No need for this. The bug title and URL below suffice. Although this makes for
a better title than the bug’s current title.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:856
> +    _page->runJavaScriptInMainFrame(scriptString,
WebKit::ScriptValueCallback::create([](bool b,
WebKit::WebSerializedScriptValue* sv){}));

We typically don’t name unused parameters.