[webkit-reviews] review granted: [Bug 124838] Improve renderer classes for MathML Token elements : [Attachment 226326] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Frédéric Wang
<fred.wang at free.fr>'s request for review:
Bug 124838: Improve renderer classes for MathML Token elements
https://bugs.webkit.org/show_bug.cgi?id=124838

Attachment 226326: Patch
https://bugs.webkit.org/attachment.cgi?id=226326&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226326&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:649
>	       return toRenderText(*m_renderer).text();

indentation seems wrong on this line

> Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:55
> +    m_open = open.isNull() ? "(" : open;

we should make this a constant at the top of the file probably.

> Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:59
> +    m_close = close.isNull() ? ")" : close;

ditto