[webkit-reviews] review granted: [Bug 129859] Subpixel rendering: Transform origin is miscalculated when RenderLayer's offsetfromRenderer has device pixel fraction value. : [Attachment 226244] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 8 19:44:41 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 129859: Subpixel rendering: Transform origin is miscalculated when
RenderLayer's offsetfromRenderer has device pixel fraction value.
https://bugs.webkit.org/show_bug.cgi?id=129859

Attachment 226244: Patch
https://bugs.webkit.org/attachment.cgi?id=226244&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226244&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:845
> +	   LayoutRect
layerBounds(LayoutPoint(roundedForPainting(offsetFromParent,
deviceScaleFactor)), borderBox.size());

It's a bit odd that the origin is device-pixel snapped, but the size is not.
Does this work for large boxes where a percentage transform-origin could be
visibly affected by the exact size?


More information about the webkit-reviews mailing list