[webkit-reviews] review granted: [Bug 129977] [WK2] Improve the network process low memory handler. : [Attachment 226236] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 129977: [WK2] Improve the network process low memory handler.
https://bugs.webkit.org/show_bug.cgi?id=129977

Attachment 226236: Patch
https://bugs.webkit.org/attachment.cgi?id=226236&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226236&action=review


> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:55
> +#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

I think we should call this PLATFORM(MAC) now instead of !PLATFORM(IOS).

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:120
> +    UNUSED_PARAM(critical);

I suggest commenting out the argument name instead of using UNUSED_PARAM, since
the former will actually give a compile error if we use the thing we say we’re
not using.

> Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm:123
> +    RetainPtr<CFURLCacheRef> cache =
adoptCF(CFURLCacheCopySharedURLCache());
> +    _CFURLCachePurgeMemoryCache(cache.get());

I think you should do this as a one-liner. No need for the local.