[webkit-reviews] review denied: [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext. : [Attachment 226121] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 129740: [EFL] Add WK2 API to control TLS error policy on WebContext.
https://bugs.webkit.org/show_bug.cgi?id=129740

Attachment 226121: patch
https://bugs.webkit.org/attachment.cgi?id=226121&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226121&action=review


I think we need to test _get() as well. Can't you test _get() in tests ?

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:362
> +Eina_Bool ewk_context_ignore_tls_errors_get(Ewk_Context *ewkContext);

1. Missing const keyword in parameter. Ewk_Context -> const Ewk_Context
2. Use context to be sync with existing APIs.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:370
> +EAPI void ewk_context_ignore_tls_errors_set(Ewk_Context *ewkContext,
Eina_Bool ignore_tls_errors);

ditto.