[webkit-reviews] review granted: [Bug 129812] [Mac] Don't perform a round-trip through WebProcess before interpreting key events : [Attachment 226148] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 129812: [Mac] Don't perform a round-trip through WebProcess before
interpreting key events
https://bugs.webkit.org/show_bug.cgi?id=129812

Attachment 226148: proposed patch
https://bugs.webkit.org/attachment.cgi?id=226148&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226148&action=review


> Source/WebCore/dom/KeyboardEvent.h:102
> +    const Vector<KeypressCommand>& keypressCommands() const { return
m_keypressCommands; }
> +
> +    // This is only needed for WebKit1 - with WebKit2, the commands are
delivered from UI process.
>      Vector<KeypressCommand>& keypressCommands() { return m_keypressCommands;
}

I just noticed the strange fact that the const overload for this is in a
different paragraph from the non-const overload. You should fix that.

> Source/WebCore/platform/KeypressCommand.h:34
> +#if PLATFORM(COCOA)

Should this wrap the whole file instead of just the struct?

> Source/WebCore/platform/KeypressCommand.h:45
> +
> +

Extra blank space here.