[webkit-reviews] review granted: [Bug 129938] [iOS WebKit2] Long-press on a link shows just "Copy" : [Attachment 226186] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 129938: [iOS WebKit2] Long-press on a link shows just "Copy"
https://bugs.webkit.org/show_bug.cgi?id=129938

Attachment 226186: Patch
https://bugs.webkit.org/attachment.cgi?id=226186&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226186&action=review


> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1474
> +

Blank line here.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1481
> +	       info.title =
element->getAttribute(HTMLNames::titleAttr).string();

This could be a fastGetAttribute(), HTMLNames::titleAttr cannot be animated.