[webkit-reviews] review denied: [Bug 129895] Update the install guidelines for perf.webkit.org : [Attachment 226143] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 129895: Update the install guidelines for perf.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=129895

Attachment 226143: Patch
https://bugs.webkit.org/attachment.cgi?id=226143&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226143&action=review


> Websites/perf.webkit.org/Install.md:19
> +## Start Server application

This sounds as if using Server app is necessary. We should emphasize that this
is discouraged.

> Websites/perf.webkit.org/Install.md:-26
> -## Edit /private/etc/apache2/httpd.conf
> + - Enable PHP web applications
> + - Go to Server Website / Store Site Files In, change it to
/Volumes/Data/WebKitPerfMonitor/public/`
> + - Go to Server Website / Edit advanced settings, enable Allow overrides
using .htaccess files
> +
> +## Edit /Library/Server/Web/Config/apache2/sites/0000_any_80.conf (and/or
0000_any_443.conf)
>  
>  1. Update ServerAdmin to your email address
> -2. Change DocumentRoot to `/Volumes/Data/WebKitPerfMonitor/public/`
> -3. Uncomment `"LoadModule php5_module libexec/apache2/libphp5.so"`
> -4. Modify the directives for the document root and / to allow overriding
`"All"`
> -5. Delete directives on CGI-Executables
> -6. Add the following directives to enable gzip:

We should keep the old instruction for the case when you didn't start Server
app.