[webkit-reviews] review granted: [Bug 129919] Set background color of WK2's UIScrollView to the pageExtendedBackgroundColor : [Attachment 226181] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 7 16:48:03 PST 2014
Benjamin Poulain <benjamin at webkit.org> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 129919: Set background color of WK2's UIScrollView to the
pageExtendedBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=129919
Attachment 226181: Patch
https://bugs.webkit.org/attachment.cgi?id=226181&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226181&action=review
> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:207
> + WebCore::Color m_pageExtendedBackgroundColor;
Let's move this above with content size.
> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:426
> + encoder << m_pageExtendedBackgroundColor;
And update this accordingly.
> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:492
> + if (!decoder.decode(result.m_pageExtendedBackgroundColor))
> + return false;
> +
And this.
> Source/WebKit2/UIProcess/WebPageProxy.h:432
> + void setPageExtendedBackgroundColor(const WebCore::Color& color) {
m_pageExtendedBackgroundColor = color; }
You should not need this.
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:340
> +
_page->setPageExtendedBackgroundColor(layerTreeTransaction.pageExtendedBackgrou
ndColor());
This should be done in WebPageProxy::didCommitLayerTree().
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:342
> + if ([self _backgroundExtendsBeyondPage] &&
pageExtendedBackgroundColor != [_scrollView backgroundColor])
You may not need pageExtendedBackgroundColor != [_scrollView backgroundColor],
UIScrollView might do that already.
> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:880
> + if (m_page->drawingArea())
> + m_page->drawingArea()->scheduleCompositingLayerFlush();
Do we really need this? I would think a flush must be scheduled already since
the style would invalidate the full frame rect.
More information about the webkit-reviews
mailing list