[webkit-reviews] review granted: [Bug 129915] Continue hangs when performing for-of over arguments : [Attachment 226183] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 129915: Continue hangs when performing for-of over arguments
https://bugs.webkit.org/show_bug.cgi?id=129915

Attachment 226183: Patch
https://bugs.webkit.org/attachment.cgi?id=226183&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226183&action=review


r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2451
> +	   emitJump(loopCondition.get());

Our other looping nodes prefer to emit op_less twice -- once at the head of the
loop, and once at the tail. That makes the CFG more amenable to optimization.