[webkit-reviews] review granted: [Bug 129600] [WebKit2][iOS] PDF : [Attachment 226106] split patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 7 15:59:46 PST 2014
Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 129600: [WebKit2][iOS] PDF
https://bugs.webkit.org/show_bug.cgi?id=129600
Attachment 226106: split patch
https://bugs.webkit.org/attachment.cgi?id=226106&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226106&action=review
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:46
> + at interface WKPDFView () {
> + RetainPtr<UIPDFDocument> _pdfDocument;
> + Vector<UIPDFPageView*> _pageViews;
> + CGSize _minimumSize;
> + UIScrollView *_scrollView;
> +}
> + at end
Just move these to the @implementation section instead.
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:55
> + [self setBackgroundColor:[UIColor grayColor]];
self.backgroundColor =
> Source/WebKit2/UIProcess/ios/WKPDFView.mm:79
> + [[pageView contentLayer] setContentsScale:self.window.screen.scale];
pageView.contentLayer.contentsScale =
More information about the webkit-reviews
mailing list