[webkit-reviews] review denied: [Bug 129781] Web Inspector: AXI: Expose checked/disabled/expanded/pressed/readonly/selected : [Attachment 226055] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied James Craig <jcraig at apple.com>'s
request for review:
Bug 129781: Web Inspector: AXI: Expose
checked/disabled/expanded/pressed/readonly/selected
https://bugs.webkit.org/show_bug.cgi?id=129781

Attachment 226055: patch
https://bugs.webkit.org/attachment.cgi?id=226055&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226055&action=review


> Source/WebCore/inspector/protocol/DOM.json:62
> +		   { "name": "checked", "type": "integer", "optional": true,
"description": "Returns checked state if supported: unchecked (0), checked (1),
or mixed (2)" },

This should be an enum not a number. That way the protocol is backwards
compatible.