[webkit-reviews] review denied: [Bug 129807] [Win64] Compile error after r165128. : [Attachment 226154] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied peavo at outlook.com's request for
review:
Bug 129807: [Win64] Compile error after r165128.
https://bugs.webkit.org/show_bug.cgi?id=129807

Attachment 226154: Patch
https://bugs.webkit.org/attachment.cgi?id=226154&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226154&action=review


Looks much better, but need one more comment so that other folks who look at
this will understand why the "|| !ENABLE(LLINT_C_LOOP)" was added, and won't
unknowingly remove it.

> Source/WTF/ChangeLog:8
> +	   * wtf/Platform.h: MSVC does not support computed goto.

You should also add a comment about the COMPUTED_GOTO_OPCODES e.g.:
"Also enabled COMPUTED_GOTO_OPCODES when !ENABLE(LLINT_C_LOOP).  This is needed
because the ASM LLINT operates like COMPUTED_GOTO_OPCODES and relies on the
related data structures being defined to support this.	On Win32, the platform
does not HAVE_COMPUTED_GOTO support, but does want ENABLE_COMPUTED_GOTO_OPCODES
because it uses the ASM LLINT."