[webkit-reviews] review granted: [Bug 129904] REGRESSION(165267): Broke a webkitpy unit tests : [Attachment 226153] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 7 13:20:26 PST 2014


Jon Honeycutt <jhoneycutt at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 129904: REGRESSION(165267): Broke a webkitpy unit tests
https://bugs.webkit.org/show_bug.cgi?id=129904

Attachment 226153: Patch
https://bugs.webkit.org/attachment.cgi?id=226153&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226153&action=review


r=me

> Tools/Scripts/webkitpy/port/gtk.py:57
>      def _is_cmake_build(self):
> -	   return os.path.exists(self._build_path('CMakeCache.txt'))
> +	   return not os.path.exists(self._build_path('config.log'))

A comment about this would help readability.


More information about the webkit-reviews mailing list