[webkit-reviews] review granted: [Bug 129897] [iOS] Add an updateID to visibleContentRect updates which is passed back in layer transactions, so we know whether transactions are stale : [Attachment 226147] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 129897: [iOS] Add an updateID to visibleContentRect updates which is passed
back in layer transactions, so we know whether transactions are stale
https://bugs.webkit.org/show_bug.cgi?id=129897

Attachment 226147: Patch
https://bugs.webkit.org/attachment.cgi?id=226147&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226147&action=review


> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:47
> +    VisibleContentRectUpdateInfo(const WebCore::FloatRect& exposedRect,
const WebCore::FloatRect& unobscuredRect, const WebCore::FloatRect&
customFixedPositionRect, double scale, uint64_t updateID, bool inStableState)

I would put the update ID first for some reason...

> Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:78
> +    // Note: the comparison doesn't include updateID.

I agree this is correct but you should probably say why here.