[webkit-reviews] review denied: [Bug 128420] AX: [GTK] Implement computedRoleString in AccessibilityUIElement : [Attachment 225799] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Diego Pino
<dpino at igalia.com>'s request for review:
Bug 128420: AX: [GTK] Implement computedRoleString in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=128420

Attachment 225799: Patch
https://bugs.webkit.org/attachment.cgi?id=225799&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
I'm not sure about this patch mainly because it tries to match an ATK object
with the text that would be returned by
AccessibilityObject::computedRoleString() if we were in the WebCore space,
based only on the AtkRole for the object.

The problem with that approach is that you are basing the mapping in
information that has been already filtered and mapped before (core a11y objects
-> ATK objects) and so you might not have now all the required information now
to be able to print what the Mac platform would print here, because the roles
exposed by ATK (and even the a11y hierarchy, which is usually flattened) are
not a 1:1 match with the roles from WebCore.

In the other hand, I do not see how to reliably extract that information in the
GTK port without directly inspecting the AccessibilityObject wrapped by the ATK
object, but by doing that you would break the encapsulation and I'm not sure
what the benefit of testing such a thing would be in the end, other than
testing what the Mac platform is testing already. And that would anyway be
exclusively related to the needs of the WebInspector, not the needs of platform
specific Assistive Technologies (such as ORCA), which is what we normally test
in the other cases (and why we only use ATK APIs from here).

So, IMHO, this function should either remain unimplemented in ATK based ports
or it should be implemented, as an exception, by breaking the encapsulation and
getting the information directly from the wrapped WebCore::AccessibilityObject.