[webkit-reviews] review granted: [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext. : [Attachment 226087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 6 23:08:44 PST 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 129676: [EFL] Replace GraphicsContext3D with Evas_GL in
AcceleratedCompositingContext.
https://bugs.webkit.org/show_bug.cgi?id=129676

Attachment 226087: Patch
https://bugs.webkit.org/attachment.cgi?id=226087&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=226087&action=review


LGTM except for my small comment.

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> +    bool resize(const IntSize&);

I think it would be good to keep it as *private* until using by other classes.


More information about the webkit-reviews mailing list