[webkit-reviews] review requested: [Bug 129864] Crash shortly after loading certain web pages : [Attachment 226086] Patch prevents shimSecItem{CopyMatching, Add, Update, Delete} from trying to use NULL implementations

[bugzilla-daemon at webkit.org]

Aaron Golden <aegolden at gmail.com> has asked  for review:
Bug 129864: Crash shortly after loading certain web pages
https://bugs.webkit.org/show_bug.cgi?id=129864

Attachment 226086: Patch prevents shimSecItem{CopyMatching,Add,Update,Delete}
from trying to use NULL implementations
https://bugs.webkit.org/attachment.cgi?id=226086&action=review

------- Additional Comments from Aaron Golden <aegolden at gmail.com>
Patch prevents the crash by guarding various methods against calling
implementations from the secItemShimCallbacks struct when those implementations
are NULL.  I'm actually not sure what the most appropriate OSStatus return
value is when the callback is NULL.  errSecUnimplemented seemed pretty good,
but maybe there's a better/more standard one.