[webkit-reviews] review denied: [Bug 129819] Let the user define the full address of the performance-site-server for uploading results : [Attachment 226029] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 129819: Let the user define the full address of the performance-site-server
for uploading results
https://bugs.webkit.org/show_bug.cgi?id=129819

Attachment 226029: Patch
https://bugs.webkit.org/attachment.cgi?id=226029&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=226029&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312
>      def _upload_json(self, test_results_server, json_path,
host_path="/api/report", file_uploader=FileUploader):
> -	   url = "https://%s%s" % (test_results_server, host_path)
> +	   url = test_results_server + host_path

This would break bots on build.webkit.org. We need to support both inputs
during the transition.
r- because of that.