[webkit-reviews] review granted: [Bug 129777] [Mac] Allow com.apple.GSSCred in WebKit sandbox profiles : [Attachment 225952] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 6 08:42:14 PST 2014


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 129777: [Mac] Allow com.apple.GSSCred in WebKit sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=129777

Attachment 225952: proposed patch
https://bugs.webkit.org/attachment.cgi?id=225952&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225952&action=review


> Source/WebKit2/ChangeLog:25
> +2014-02-25  Alexey Proskuryakov  <ap at apple.com>
> +
> +	   [iOS] Remove some erroneously captured blocks
> +	   https://bugs.webkit.org/show_bug.cgi?id=129362
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remove unused captured Objective-C block variables (capturing these
doesn't work anyway).
> +
> +	   * UIProcess/ios/WKContentViewInteraction.mm:
> +	   (-[WKContentView
requestAutocorrectionRectsForString:withCompletionHandler:]):
> +	   (-[WKContentView
requestAutocorrectionContextWithCompletionHandler:]):
> +

Please don't land this part.


More information about the webkit-reviews mailing list