[webkit-reviews] review denied: [Bug 129148] ASSERTION FAILED: span >= 1 : [Attachment 225914] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Zsolt Borbely
<borbezs at inf.u-szeged.hu>'s request for review:
Bug 129148: ASSERTION FAILED: span >= 1
https://bugs.webkit.org/show_bug.cgi?id=129148

Attachment 225914: Patch
https://bugs.webkit.org/attachment.cgi?id=225914&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225914&action=review


> LayoutTests/fast/table/incorrect-colgroup-span-values.html:6
> +	 if (window.testRunner)
> +	 testRunner.dumpAsText();

The second line here should be indented.

> LayoutTests/fast/table/incorrect-colgroup-span-values.html:12
> +	 <colgroup span="">

This is still not testing the null case; it will arrive in parseAttribute() as
an empty string, not a null one.
To get null, you need to run some JavaScript that does
element.removeAttribute("colgroup")