[webkit-reviews] review denied: [Bug 129726] [CSS Shapes] inset does not properly clamp large corner radii : [Attachment 225917] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 129726: [CSS Shapes] inset does not properly clamp large corner radii
https://bugs.webkit.org/show_bug.cgi?id=129726

Attachment 225917: Patch
https://bugs.webkit.org/attachment.cgi?id=225917&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225917&action=review


> Source/WebCore/rendering/style/BorderRadiiConstraintScale.h:29
> +template <class Rect, class Radii>
> +inline float calcBorderRadiiConstraintScaleFor(const Rect& rect, const
Radii& radii)

Cause I hate to debugs templates, I am not a huge fan of templates and would
like to avoid them as much as possible. For this particular case it seems you
just created a template to be able to use the classes Rect and Radii. Isn't
there a better way? Also, Can't you just add this to FloatRoundedRect or
RoundedRect instead of creating another header?