[webkit-reviews] review denied: [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext. : [Attachment 225946] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 23:13:33 PST 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 129676: [EFL] Replace GraphicsContext3D with Evas_GL in
AcceleratedCompositingContext.
https://bugs.webkit.org/show_bug.cgi?id=129676
Attachment 225946: Patch
https://bugs.webkit.org/attachment.cgi?id=225946&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225946&action=review
r- based on review comments.
> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:61
> + OwnPtr<Evas_GL> m_evasGL;
OwnPtr is being replaced by C+11 (e.g. std::unique_ptr) So, it would be good if
you start to use it in this patch.
Loot at the meta bug.
Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128007
More information about the webkit-reviews
mailing list