[webkit-reviews] review granted: [Bug 129749] Revise Out-of-band VTT support for better integration with AVFoundation engine : [Attachment 225931] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 129749: Revise Out-of-band VTT support for better integration with
AVFoundation engine
https://bugs.webkit.org/show_bug.cgi?id=129749

Attachment 225931: Patch
https://bugs.webkit.org/attachment.cgi?id=225931&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225931&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:5560
> -	   PlatformTextTrack::TrackKind platformKind =
PlatformTextTrack::Caption;
> +	   InbandTextTrackPrivate::Kind platformKind =
InbandTextTrackPrivate::Captions;
>	   if (trackElement.kind() == TextTrack::captionsKeyword())

What prompted the change from PlatformTextTrack::TrackKind to
InbandTextTrackPrivate::Kind? A "platform" text track can be either in-band or
out-of-band, so why does it have an InbandTextTrackPrivate::Kind and an
InbandTextTrackPrivate::Mode?

This isn't a huge deal, but I don't think it is a useful change.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:558
> +	       RetainPtr<CFStringRef> uniqueID =
String::number(track->uniqueId()).createCFString();
> +	       
> +	       if (![[currentOption.get() outOfBandIdentifier] isEqual:
reinterpret_cast<const NSString*>(uniqueID.get())])
> +		   continue;

Why not use createNSString() and avoid the cast?