[webkit-reviews] review denied: [Bug 129598] Second execution of navigator.vibration() does not wok. : [Attachment 225923] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 17:35:57 PST 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Jinwoo Jeong
<jw00.jeong at samsung.com>'s request for review:
Bug 129598: Second execution of navigator.vibration() does not wok.
https://bugs.webkit.org/show_bug.cgi?id=129598

Attachment 225923: Patch
https://bugs.webkit.org/attachment.cgi?id=225923&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225923&action=review


> Source/WebCore/ChangeLog:-1099
> -

Do not touch unrelated line.

> Source/WebKit2/ChangeLog:8
> +	   Add a vibration unit test regression after r164266.

I don't see why r164266 was influenced on vibration feature.

[CoordinatedGraphics][EFL] Remove view_source functions.
http://trac.webkit.org/changeset/164266

> Source/WebKit2/ChangeLog:9
> +	   Tighten condition of existing tests.

Add a new line.


More information about the webkit-reviews mailing list