[webkit-reviews] review denied: [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext. : [Attachment 225884] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 129740: [EFL] Add WK2 API to control TLS error policy on WebContext.
https://bugs.webkit.org/show_bug.cgi?id=129740

Attachment 225884: patch
https://bugs.webkit.org/attachment.cgi?id=225884&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225884&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_context.h:361
> +EAPI void ewk_context_set_ignore_tls(Ewk_Context* ewkContext, Eina_Bool
ignoreTLSErrors);

1. Wrong * place and wrong efl function style. Ewk_Context* ewkContext =>
Ewk_Context *ewk_context, ignoreTLSErrors => ignore_tls_errors.

2. Generally EFL function naming has placed *verb* at the end of function. For
instance, ewk_context_ignore_tls_set(...)

>
Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:24
> +EWK2UnitTestServer::EWK2UnitTestServer(GTlsCertificate* tls_cert)

We only use EFL coding style in public EFL APIs. So, tls_cert => tlsCert

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:29
> +    EWK2UnitTestServer(GTlsCertificate* tls_cert = 0);

ditto

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:41
> +static bool finish_test = false;

ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:152
> +    Ewk_Error* error = 0;

0 => nullptr ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:178
> +    Ewk_Error* error = 0;

ditto.