[webkit-reviews] review granted: [Bug 129753] ASSERT(newestManifest) fails in WebCore::ApplicationCacheGroup::didFinishLoadingManifest() : [Attachment 225919] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 129753: ASSERT(newestManifest) fails in
WebCore::ApplicationCacheGroup::didFinishLoadingManifest()
https://bugs.webkit.org/show_bug.cgi?id=129753

Attachment 225919: Patch
https://bugs.webkit.org/attachment.cgi?id=225919&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225919&action=review


> Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1186
> +	   LOG_ERROR("No manifest resource was in the cache");

I'd say: "Could not load application cache, because there was no manifest
resource".

> Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1476
> +	   if (!deleteCacheGroupRecord(manifestURL)) {
>	       LOG_ERROR("Could not load cache group id, error \"%s\"",
m_database.lastErrorMsg());

This log message doesn't look right now.