[webkit-reviews] review granted: [Bug 129755] More FTL ARM fixes : [Attachment 225908] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 13:43:45 PST 2014


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 129755: More FTL ARM fixes
https://bugs.webkit.org/show_bug.cgi?id=129755

Attachment 225908: the patch
https://bugs.webkit.org/attachment.cgi?id=225908&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225908&action=review


r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   - Temporarily switch to allocating all MCJIT memory in the
executable pool on non-x86
> +	     platforms.

Can you file a bug about undoing this?

> Source/JavaScriptCore/ftl/FTLDataSection.h:39
> +    DataSection(VM&, CodeBlock*, size_t size, unsigned alignment);

Nix "size", please.


More information about the webkit-reviews mailing list