[webkit-reviews] review granted: [Bug 129741] JSCell::m_gcData should encode its information differently : [Attachment 225905] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 129741: JSCell::m_gcData should encode its information differently
https://bugs.webkit.org/show_bug.cgi?id=129741

Attachment 225905: Patch
https://bugs.webkit.org/attachment.cgi?id=225905&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225905&action=review


r=me

Is speedup?

> Source/JavaScriptCore/runtime/JSCell.h:150
> +    void mark() { m_gcData = Marked; }

I would call this "setMarked".

> Source/JavaScriptCore/runtime/JSCell.h:151
> +    void remember() { ASSERT(m_gcData == Marked); m_gcData =
MarkedAndRemembered; }

"setRemembered(true)"

> Source/JavaScriptCore/runtime/JSCell.h:152
> +    void forget() { ASSERT(m_gcData == MarkedAndRemembered); m_gcData =
Marked; }

"setRemembered(false)"