[webkit-reviews] review granted: [Bug 129723] [iOS] Show external device name/type in placeholder : [Attachment 225848] Out damned space!

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 129723: [iOS] Show external device name/type in placeholder
https://bugs.webkit.org/show_bug.cgi?id=129723

Attachment 225848: Out damned space!
https://bugs.webkit.org/attachment.cgi?id=225848&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225848&action=review


r=me, with nit.

> Source/WebCore/html/HTMLMediaSession.cpp:217
> +String HTMLMediaSession::wirelessPlaybackTargetDisplayName(const
HTMLMediaElement& element) const
> +{
> +    MediaPlayer* player = element.player();
> +    if (!player) {
> +	   LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName -
returning \"\" because player is NULL");
> +	   return emptyString();
> +    }
> +    
> +    String name = player->wirelessPlaybackTargetName();
> +    LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName -
returning \"%s\"", name.utf8().data());
> +    
> +    return name;
> +}
> +
> +MediaPlayer::WirelessPlaybackTargetType
HTMLMediaSession::wirelessPlaybackTargetType(const HTMLMediaElement& element)
const
> +{
> +    MediaPlayer* player = element.player();
> +    if (!player) {
> +	   LOG(Media, "HTMLMediaSession::wirelessPlaybackTargetType - returning
0 because player is NULL");
> +	   return MediaPlayer::TargetTypeNone;
> +    }
> +    
> +    MediaPlayer::WirelessPlaybackTargetType type =
player->wirelessPlaybackTargetType();
> +    LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName -
returning %i", static_cast<int>(type));
> +    
> +    return type;
> +}
> +    

Why is this being routed through HTMLMediaSession?  It seems like this could
either go into the MediaControlsHost or HTMLMediaElement.